Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add examples for new grpc endpoints #794

Merged
merged 8 commits into from
Nov 6, 2024
Merged

Add examples for new grpc endpoints #794

merged 8 commits into from
Nov 6, 2024

Conversation

illia-malachyn
Copy link
Contributor

Closes: #784

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.47%. Comparing base (2f7fa8b) to head (7c952ed).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #794      +/-   ##
==========================================
+ Coverage   56.59%   57.47%   +0.88%     
==========================================
  Files          35       35              
  Lines        7305     7454     +149     
==========================================
+ Hits         4134     4284     +150     
+ Misses       2670     2660      -10     
- Partials      501      510       +9
Flag Coverage Δ
unittests 57.47% <ø> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn illia-malachyn mentioned this pull request Oct 28, 2024
Closed
@illia-malachyn
Copy link
Contributor Author

I get a nil pointer dereference exception when running the send-and-subscribe-transaction-statuses example. The cause might be hidden in the method implementation in flow-go repo. I will open an issue for this.

What's more, the stream-account-statuses example doesn't work due to this issue onflow/flow-go#6575

@illia-malachyn illia-malachyn mentioned this pull request Oct 29, 2024
Closed
@franklywatson franklywatson merged commit bbbded5 into onflow:master Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterargue peterargue peterargue approved these changes

@nvdtf nvdtf nvdtf approved these changes

@janezpodhostnik janezpodhostnik Awaiting requested review from janezpodhostnik janezpodhostnik is a code owner

@chasefleming chasefleming Awaiting requested review from chasefleming chasefleming is a code owner

@jribbink jribbink Awaiting requested review from jribbink jribbink is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Try out the new streaming endpoints and ensure the endpoint interfaces are ergonomic
5 participants
@illia-malachyn @codecov-commenter @nvdtf @peterargue @franklywatson